Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for Swift 2.3 #128

Closed
wants to merge 1 commit into from
Closed

Updated for Swift 2.3 #128

wants to merge 1 commit into from

Conversation

davbeck
Copy link

@davbeck davbeck commented Jun 16, 2016

No breaking code changes applied to this project for Swift 2.3, just an update to the project to set it's version.

I'm submitting this request to master, but I believe that there should be a 2.3 branch instead. What I would propose as the timeline would be:

  1. Maintain 2.3 and 3.0 branches until Xcode 8 GM is released.
  2. Keep the 2.3 branch long term for legacy support.
  3. Merge 3.0 into master.
  4. When the next version of Swift is released, create a legacy swift-3.0 branch off of master.

This way, user's of the framework can target a specific branch if they need legacy support, or master if they want the most current version.

Thoughts?

No breaking code changes applied to this project for Swift 2.3, just an update to the project to set it's version.
@davbeck davbeck mentioned this pull request Jun 17, 2016
DasHutch added a commit to DasHutch/Locksmith that referenced this pull request Jun 26, 2016
Updated for Swift 2.3 (Updated for Swift 2.3 matthewpalmer#128)
@matthewpalmer
Copy link
Owner

Thanks very much! I'll do a bit of work on Locksmith over the weekend and get this merged in

@matthewpalmer
Copy link
Owner

Merged into swift-2.3. Cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants