Fix memoization for optional args #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a fixed :memoist_reload argument instead of depending on argument order as it is fragile in case of optional and named args. This change maintains backward compatibility for methods that don't have optional/named arguments.
Fix for optional arguments
|
@ashu210890 any idea why this breaks all the tests? which bit isn't backwards compatible? |
|
@ashu210890 this seems like a worthwhile fix ... are you still interested in getting it merged? |
sebjacobs
force-pushed
the
master
branch
2 times, most recently
from
9d66c95
to
34f90dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76