Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use install executable to obtain libpact #3

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

matthewshirley
Copy link
Owner

Summary

This PR changes the installation to process by asking users to run the install executable that grabs the appropriate libpact. This is installed to the user library path.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #3 (3775519) into main (76fd662) will increase coverage by 0.34%.
The diff coverage is 80.00%.

❗ Current head 3775519 differs from pull request most recent head a1f16c0. Consider uploading reports for the commit a1f16c0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   84.88%   85.22%   +0.34%     
==========================================
  Files           8        8              
  Lines         172      176       +4     
==========================================
+ Hits          146      150       +4     
  Misses         26       26              
Impacted Files Coverage Δ
lib/src/ffi/dylib.dart 76.92% <80.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76fd662...a1f16c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants