Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basis_spline stateful transform. #21

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

matthewwardrop
Copy link
Owner

This patch adds an implementation of basis splines into formulaic. It's performance beats that of scipy's splev for our use cases, and so we do not use it here.

This patch highlighted a few deficiencies elsewhere in the stack (such as implicit sparse matrix encoding), and this needs to be unit tested, and so this will sit here for a while until those issues are sorted.

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        31    +1     
  Lines         1233      1286   +53     
=========================================
+ Hits          1233      1286   +53     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
formulaic/materializers/transforms/basis_spline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93be547...b367270. Read the comment docs.

@matthewwardrop matthewwardrop merged commit 174db5c into master Jul 27, 2020
@matthewwardrop matthewwardrop deleted the add_basis_splines branch July 27, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant