Add basis_spline stateful transform. #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an implementation of basis splines into
formulaic
. It's performance beats that ofscipy
'ssplev
for our use cases, and so we do not use it here.This patch highlighted a few deficiencies elsewhere in the stack (such as implicit sparse matrix encoding), and this needs to be unit tested, and so this will sit here for a while until those issues are sorted.