fix units dimensionless in plots

matthiaskoenig · Mar 4, 2021 · 3387445 · 3387445
1 parent 0d813ee
commit 3387445
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/release-notes/next-release.md b/release-notes/next-release.md
@@ -1,2 +1,3 @@
 # Release notes for sbmlsim x.y.z
 - breaking changes in units handling
+- bugfix plotting `dimensionless` units in labels
diff --git a/src/sbmlsim/plot/plotting.py b/src/sbmlsim/plot/plotting.py
@@ -306,7 +306,10 @@ def __init__(
         if unit is None:
             unit = "?"
         if not name:
-            name = f"{label} [{unit}]"
+            if unit != "dimensionless":
+                name = f"{label} [{unit}]"
+            else:
+                name = f"{label} [-]"
 
         self.label = label
         self.name = name

diff --git a/src/sbmlsim/plot/plotting_matplotlib.py b/src/sbmlsim/plot/plotting_matplotlib.py
@@ -83,13 +83,13 @@ def get_scale(axis):
 
             ridx = subplot.row - 1
             cidx = subplot.col - 1
-            ax = fig.add_subplot(
+            ax: plt.Axes = fig.add_subplot(
                 gs[ridx : ridx + subplot.row_span, cidx : cidx + subplot.col_span]
-            )  # type: plt.Axes
+            )
 
             plot = subplot.plot
-            xax = plot.xaxis  # type: Axis
-            yax = plot.yaxis  # type: Axis
+            xax: Axis = plot.xaxis
+            yax: Axis = plot.yaxis
 
             # units
             if xax is None: