fix: fix flake8 errors in report module #189
Conversation
sankha555
commented
Feb 12, 2021
sankha555
commented
- fix Fix flake8 issues in report module #188
- generated a test report for flake8 errors in reports module and fixed the errors in doc strings and formatting.
- tests passed
Codecov Report
@@ Coverage Diff @@
## develop #189 +/- ##
========================================
Coverage 68.46% 68.46%
========================================
Files 62 62
Lines 4253 4253
Branches 721 721
========================================
Hits 2912 2912
Misses 1113 1113
Partials 228 228
Continue to review full report at Codecov.
|
|
@matthiaskoenig I have made the changes in module according to the errors generated by the flake8 run. I changed the function summary description in a few places to make it a bit concise. In some of the strings in I am a bit confused about what best change I should incorporate for a few instances in the files, which I have asked in the comments in the corresponding line. Please take a look at them and kindly suggest me how I should proceed regarding them. If there are any other changes that I should make, please let me know. Thanks! |
| @@ -169,12 +169,17 @@ def boundsStringFromReaction(reaction: libsbml.Reaction, model: libsbml.Model) - | |||
| if ub_p.isSetValue(): | |||
| ub_value = ub_p.getValue() | |||
| if (lb_value is not None) or (ub_value is not None): | |||
| bounds = f'<code>[{lb_value} <i class="fa fa-sort fa-rotate-90" aria-hidden="true"></i> {ub_value}]</code>' | |||
| bounds = f""" | |||
There was a problem hiding this comment.
One of the instances, where I have made the HTML code multi-line to overcome the flake8 error
There was a problem hiding this comment.
In the first doc string for the files xslt/math.py (line 2) and formating.py(line 2), flake8 says that they should be single line doc-strings. Should I convert them to single line doc strings or shall Iet them be as they are. If we need to update those doc strings in the future to add more detail, then we might have to convert them to multi-line doc strings. Hence I wanted to take your suggestion on what would be best way to go about them.
There was a problem hiding this comment.
xlst will be removed soon, so no updates here. Multi-line comment is fine.
