Skip to content

Commit

Permalink
Make sure expired items are also stored (they may override existing v…
Browse files Browse the repository at this point in the history
…alue)

Stop trying to be clever! :)
  • Loading branch information
matthiasmullie committed May 9, 2016
1 parent a685f48 commit 6b739a8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Changelog


## [1.2.2] - 2016-05-09
### Fixed
- Make sure expired items are also stored (they may override existing value)


## [1.2.1] - 2016-04-05
### Fixed
- Made MySQL's value a LONGBLOB, which can store bigger values
Expand Down Expand Up @@ -168,3 +173,4 @@
[1.1.0]: https://github.com/matthiasmullie/scrapbook/compare/1.0.10...1.1.0
[1.2.0]: https://github.com/matthiasmullie/scrapbook/compare/1.1.0...1.2.0
[1.2.1]: https://github.com/matthiasmullie/scrapbook/compare/1.2.0...1.2.1
[1.2.2]: https://github.com/matthiasmullie/scrapbook/compare/1.2.1...1.2.2
5 changes: 0 additions & 5 deletions src/Psr6/Pool.php
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,6 @@ public function save(CacheItemInterface $item)
);
}

if ($item->isExpired()) {
// already expired: don't even save it
return true;
}

if (!$item->hasChanged()) {
/*
* If the item didn't change, we don't have to re-save it. We do,
Expand Down

0 comments on commit 6b739a8

Please sign in to comment.