feat: incoming verification request #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for incoming verification requests when the verification step for a Matrix room participant is initiated by another member of the room. This now enables instances of Lotti to verify each other, which is required for synchronization to take place, as no outgoing sync message will emitted when there's any unverified member in the room. This prevents the scenario where an eavesdropper could enter a room and listen in. As long as we trust the server, this would not necessarily become an issue if a room indeed remains private, but I don't want to have to trust any server with my private data unless end-to-end encrypted and with no way to intercept messages.