testing travis

[cordoval]

Q	A
Bug Fix?	n
New Feature?	n
BC Breaks?	n
Deprecations?	n
Tests Pass?	n
Fixed Tickets
License	MIT
Doc PR

[matthiasnoback]

Travis doesn't do anything with this, does it? It stops at #c1c117e. Maybe if you try less env combinations? It feels like this is overkill anyway. PHPUnit 4 only has to be checked once I guess, what do you think?

[cordoval]

is doing it on my branch https://travis-ci.org/cordoval/SymfonyDependencyInjectionTest/builds/23123378

[cordoval]

yes is an overkill and travis does not like that, mine is running and i see a lot of errors.

Could you please paste the reduced set sufficient combinations you want me to test?

[matthiasnoback]

Interesting. But the errors are about PHP strict mode or something?

[cordoval]

yes but it is because of the madness of combinations, it is imo a very bad idea to want to support the world. we should tag it and it already is and move on with bleeding edge, minimum 3.7.34 or such and 4.x bleeding. Supporting sf2.0 is not good, not even 2.1, i mean, we are on 2.4 -> ready to move to 2.5. I suggest to remove the support for most of them.

[matthiasnoback]

What about:

- SYMFONY_VERSION=2.4.* PHPUNIT_VERSION=~3.7
- SYMFONY_VERSION=2.0.* PHPUNIT_VERSION=~4.0
- SYMFONY_VERSION=2.1.* PHPUNIT_VERSION=~4.0
- SYMFONY_VERSION=2.2.* PHPUNIT_VERSION=~4.0
- SYMFONY_VERSION=2.3.* PHPUNIT_VERSION=~4.0
- SYMFONY_VERSION=2.4.* PHPUNIT_VERSION=~4.0
- SYMFONY_VERSION=dev-master PHPUNIT_VERSION=~4.0

I guess we should aim for PHPUnit 4.0 but offer support for widely used ~3.7 versions.

[cordoval]

ok doing that

[matthiasnoback]

As we've learned there are some real differences between the versions so I don't yet want to stop support for 3.7.

[cordoval]

me neither, i am using it 👶

[cordoval]

also why testing with dev-master? since it is unstable we don't want that right?

[matthiasnoback]

Ah yes, I didn't look at it that way - you're right!

2014-04-16 16:13 GMT+02:00 Luis Cordova notifications@github.com:

also why testing with dev-master? since it is unstable we don't want that
right?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/28#issuecomment-40603276
.

Noback's Office
http://nobacksoffice.nl
+31(0)614995363

[cordoval]

@matthiasnoback ok i believe the weird error is because we were doing require -dev and keeping the dependencies of the default phpunit install 4.0, so it would pull things like phpunit-mock that are after earlier versions. I have done some changes to easy travis work and see. Then we can uncomment the madness. Imo, one should just comment those out mostly and maybe everyonce in a while test only for when doing major releases, at least a minor number bump up. This is the equivalent of [silence ci] or whatever that tag is.

[cordoval]

@matthiasnoback hmm i think the error is weird, i did all the changes but this happened again. Hmm please check if you get a chance. I will check another time.

[matthiasnoback]

Well, we should try:

composer require --no-update ...
composer require --no-update ...
composer update

This has helped in other situations too.

[cordoval]

ok on this

[cordoval]

@matthiasnoback ship it boss 👶

[cordoval]

👍 finito

[matthiasnoback]

Could you maybe pull the latest changes from master and squash the commits?

[cordoval]

done @matthiasnoback

[matthiasnoback]

Thanks @cordoval!