Closure variants for hydration #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I should move the PHP7-specific implementation to a new package so that code coverage remains 100% |
|
Looks great! Sorry for the delay.
|
|
@haampie What's the status of this? Would you be able to finish this PR? |
|
Hey @haampie, I just released a new major version which only supports PHP ^7.0. Maybe that helps to get this PR ready? If you're not interested in pushing it, just let me know, that's okay too :) |
|
Sorry, it's been a while, I'll dig into it ;) |
haampie
force-pushed
the
feature-closure-variants-for-hydration
branch
from
aaec435
to
74d0024
Compare
haampie
force-pushed
the
feature-closure-variants-for-hydration
branch
from
74d0024
to
1392a12
Compare
haampie
force-pushed
the
feature-closure-variants-for-hydration
branch
from
1392a12
to
68b7076
Compare
haampie
force-pushed
the
feature-closure-variants-for-hydration
branch
from
68b7076
to
e9a270b
Compare
|
I think this is ready to be merged after rebasing a couple times :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (among some minor details) two new Hydrate implementations, which exploit closure binding via
Closure::bindToandClosure::call(PHP7).If support for PHP 5.5 must be provided, I'm of course willing to update this PR. The closure trick works on PHP 5.5 as well.