Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unserialization behaviour and form integration test #4

Closed
wants to merge 5 commits into from
Closed

Fix unserialization behaviour and form integration test #4

wants to merge 5 commits into from

Conversation

dzubchik
Copy link
Contributor

@dzubchik dzubchik commented Mar 9, 2017

Fixes #3

@coveralls
Copy link

coveralls commented Mar 9, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 009c5f4 on dzubchik:master into ** on matthiasnoback:master**.

@coveralls
Copy link

coveralls commented Mar 9, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 009c5f4 on dzubchik:master into ** on matthiasnoback:master**.

@dzubchik
Copy link
Contributor Author

dzubchik commented Mar 9, 2017

Didn't noticed 2 commits, so this also fixes #5

@dzubchik dzubchik changed the title Fix unserialization behaviour Fix unserialization behaviour and from integration test Mar 10, 2017
@matthiasnoback
Copy link
Owner

Great work. It would be interesting to demonstrate in a test case that the behavior of an unserialized object is still the same as it was. Maybe you could run the same tests for both "fresh" and "unserialized" objects (possibly using a data provider?).

@coveralls
Copy link

coveralls commented Mar 12, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling b08aae7 on dzubchik:master into ** on matthiasnoback:master**.

@dzubchik dzubchik changed the title Fix unserialization behaviour and from integration test Fix unserialization behaviour and form integration test Mar 14, 2017
@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 16a7fd6 on dzubchik:master into ** on matthiasnoback:master**.

@coveralls
Copy link

coveralls commented Mar 28, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 9f62a53 on dzubchik:master into ** on matthiasnoback:master**.

@matthiasnoback
Copy link
Owner

I traced back your steps on my machine, merged with master and published a new version 0.2.0 which fixes unserialize behavior. Thanks for your work!

@matthiasnoback matthiasnoback mentioned this pull request Mar 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dzubchik @coveralls @matthiasnoback