Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FsiEvaluationSession is disposable #5

Closed
dsyme opened this issue Sep 27, 2015 · 1 comment
Closed

FsiEvaluationSession is disposable #5

dsyme opened this issue Sep 27, 2015 · 1 comment

Comments

@dsyme
Copy link
Contributor

dsyme commented Sep 27, 2015

FsiEvaluationSession is IDisposable, and failing to dispose it may leak considerable resources since it installs an assembly resolve handler which in turn holds on to a lot of other resources.

it would be best if the ScriptHost revealed this and allowed the caller to dispose of the ScriptHost.
matthid added a commit that referenced this issue Sep 28, 2015
@matthid
make scripthost disposable, fixes #5.
8b1bc45
@matthid matthid mentioned this issue Sep 28, 2015
Merged
@matthid
Copy link
Owner

matthid commented Sep 28, 2015

Thank you!

@matthid matthid mentioned this issue Sep 28, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthid @dsyme