Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Posting binary image data in chat causes crash #37

Closed
bryanh-9 opened this issue Feb 9, 2015 · 5 comments
Closed

Posting binary image data in chat causes crash #37

bryanh-9 opened this issue Feb 9, 2015 · 5 comments
Labels

Comments

@bryanh-9
Copy link

bryanh-9 commented Feb 9, 2015

Easily reproducible, pasting binary image data to chat in a channel where the bot resides seems to make it crash. That is to say, not a link to an image, but the actual image itself, to make it show inline.

Steps to reproduce:
Find any random image in your browser, "Copy Image" from context menu.
Right click on channel name in mumble, send message, paste it in the contents
Send it.

Poof, crash.

If this is something isolated to just me and you can't reproduce it, I can get a log soon when everyone's done using mumble for the day.

@bryanh-9 bryanh-9 changed the title Posting an image in channel crashes bot Posting binary image data in chat causes crash Feb 9, 2015
@matthieugrieger
Copy link
Owner

Thanks for the bug report! I just tried this on my own server and it does the same thing for me. I'm pretty sure I know what the issue is, I will get it fixed as soon as I can.

What's weird is that it doesn't crash when in the root channel for me... only if it is in a subchannel.

@bryanh-9
Copy link
Author

bryanh-9 commented Feb 9, 2015

Huh, that is odd. It's always been sat in a sub-channel for me, so I hadn't noticed that.

Either way, thanks for the quick response and support such an awesome program! I just started using it, and everyone loves it. I had a couple of feature ideas to throw at you, I'll open an separate item in a little bit.

@mkody
Copy link
Contributor

mkody commented Feb 9, 2015

I can confirm that we're having the same bug on our server, and it crash on the root channel too.

@matthieugrieger
Copy link
Owner

Interesting. No worries though. I think I know the fix, I just need to get
out of class to fix it. :)
On Feb 9, 2015 12:25 PM, "Kdy" notifications@github.com wrote:

I can confirm that we're having the same bug on our server, and it crash
on the root channel too.


Reply to this email directly or view it on GitHub
#37 (comment)
.

@matthieugrieger
Copy link
Owner

This should fix it. Let me know if there are any other issues!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants