Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Details page: chords only display with keyboard/swipe navigation to next/previous item #47

Closed
matthiku opened this issue Feb 29, 2016 · 4 comments
Assignees

Comments

@matthiku
Copy link
Owner

This would be mainly used by the musicians during the service to replace any other means (printouts, music sheets etc.)

Chords should be displayed properly above the lyrics.

@matthiku matthiku self-assigned this Feb 29, 2016
@matthiku
Copy link
Owner Author

An extended version of this would be to implement a Key Change - to allow musicians to change the keys for the display!

matthiku added a commit that referenced this issue Feb 29, 2016
matthiku pushed a commit that referenced this issue Feb 29, 2016
@matthiku
Copy link
Owner Author

matthiku commented Mar 1, 2016

Mainly resolved - remaining issues are:

  • allow keyboard and touch navigation; e.g. swipe left and right to go to the next/previous item
  • show title of previous and next item in the navbar(s)

@matthiku matthiku changed the title Item Details page: chords only display with button to go to next/previous item Item Details page: chords only display with keyboard/swipe navigation to next/previous item Mar 1, 2016
matthiku added a commit that referenced this issue Mar 1, 2016
@matthiku
Copy link
Owner Author

matthiku commented Mar 1, 2016

Additionally, we could re-write the chords (which are currently shown in a <pre> tag on the front-end and give the lyrics a different colour from the chords.

Basically, we would use a JavaScript function to read in the whole chords content, and re-write each line in a separate <pre> tag, using a red font for the actual chords.

TODO: figure out how to

  • best distinguish chords from the lyrics
  • split the text into lines

matthiku added a commit that referenced this issue Mar 1, 2016
@matthiku
Copy link
Owner Author

matthiku commented Mar 1, 2016

All done and dusted.

@matthiku matthiku closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant