Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] disneyplus: support adding items to library #670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hbrunn
Copy link

@hbrunn hbrunn commented Jan 27, 2024

adding to library works for series and movies, but you have to add $ADDON_PROFILE/{movies,series} manually to your library paths currently.

Missing features (not sure if they all need to be addressed in this PR):

  1. add $ADDON_PROFILE/{movies,series} to library paths automatically on update/installation
  2. have a background job that adds newly added episodes for added series
  3. allow removing from library
  4. give visual feedback when adding whole series to the library
  5. ?write nfo files with metadata?

@matthuisman
Copy link
Owner

this looks pretty close for my plan for a generic add to library that i can do at the common layer.
My biggest issue I didnt want to sanitise the filenames from the content name.
I was hoping Kodi would allow me to just put the name in the nfo file.

then id name the strm as the content_id and have a nfo next to it with the title / year in it.
Then i wanted Kodi scrapers to pull the meta from the scrapers (fill in the missing info)

@hbrunn
Copy link
Author

hbrunn commented Jan 28, 2024

I've been dabbling with that this morning, but given

$ cat ~/.kodi/userdata/addon_data/slyguy.disney.plus/movies/141d2581-a35b-466c-b9c6-e660a1443876.nfo 
<?xml version='1.0' encoding='utf8'?>
<movie><title>The Creator</title><year>2023</year><premiered>2023-09-27</premiered></movie>

$ cat ~/.kodi/userdata/addon_data/slyguy.disney.plus/movies/141d2581-a35b-466c-b9c6-e660a1443876.strm 
plugin://slyguy.disney.plus/?_=play&content_id=141d2581-a35b-466c-b9c6-e660a1443876&profile_id=XXXX

I don't manage to have kodi's scrapers amend the info from the nfo file. I can only override all local data, but then it will search for the filename again. Am I missing something here?

For me this would mean back to the above, while possibly piping the name through https://pypi.org/project/pathvalidate and adding the year to the name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants