Add ability to specify a custom sorting function for a column #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to specify a custom sorting function for a column
|
Your patch sounds reasonable, but unfortunately it no longer applies cleanly. Please fix that (and maybe #73 at the same time since they are bound to be in conflict with this one?) and then I can merge it. |
|
@tbroadley Can you resubmit? Your changes are mostly still good, just don't need the default compare anymore. If you don't have time I'll make your changes on top of master and submit the PR. |
|
@SergeyCherman Sure, I'll fix the merge conflicts right now. |
tbroadley
force-pushed
the
feature/custom-sort
branch
2 times, most recently
from
e86da32
to
e51f96f
Compare
|
@SergeyCherman Could you please take another look at these changes? |
|
Looks good to me, thanks for the quick turn around! |
|
@mattiash can you take a look and consider a merge and version bump? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.