Only look up SIDs as found in logs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can take a while, so wait until a function that uses them is run, rather than looking up at module load. Could also look up SIDs on demand rather than the whole domain at once.
Getting all accounts can be slow, and often only a small number of accounts show up in the logs.
mattifestation
approved these changes
Feb 19, 2022
There was a problem hiding this comment.
This change is awesome. Thank you so much for taking the time to think this through, implement it, and submit the PR, @theaquamarine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-CimInstance Win32_Accountcan be very slow, so start by delaying it untilGet-WDACApplockerScriptMsiEventorGet-WDACCodeIntegrityEventis used rather than doing it at module import.I then switched to only looking up SIDs as they were found in the logs rather than looking up all domain accounts to save time, since generally only a relatively small number of accounts appear in the logs.