Fix dedup merged linestrings #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how non-shared arcs are merged, when possible.
Original codebase did not detect a single shared coordinate as junction and also start of geometries were not seen as a junction. This is changed in the last year and now this need some side solving of side effects.
The new approach detects which arcs were merged and set the merged linestring on the highest index of the arcs that are part of this merged linestring.
The remaining indici are collected and set to NaN, when bookkeeping for all other arcs are maintained. The implemented approach is very similar to the deduplication of duplicate linestrings.
A new test was added and all existing tests still pass.
Fix #104