Fix to gdf use to geojson #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
to_gdf()function. I'm stepping away from the build-in TopoJSON driver within OGR/Fiona, since it is not robust enough.Fiona cannot handle nested GeometryCollections and, more important, ignores winding order.
The
to_gdf()function now serializes the GeoDataFrame through internally serializing to GeoJSON first.Moreover, the
to_geojson()function was failing when polygons somehow ended-up with only 2 coordinates (eg due to oversimplification), This PR now extends the coordinates with its first coordinate when creating a GeoJSON format if this happens. Aligning itself hereby with the Javascript topojson-client codebase.Fix #102