Do not modify source data, include geojson from file and compute bbox consistently #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #137 and #138 and a bit more.
The source data of from json-dicts are deepcopied on feature collection level, so cannot be modified anymore.
The load-from-topojson-code is moved to a
serialize_as_topojson()function. In this function there is code introduced to get the bbox even when the arcs are quantised and delta encoded.Also modifications are added that this
bboxis correctly computed in case oftoposimplifyandtopoquantize.Also this PR introduce the ability to directly parse GeoJSON type FeatureCollection from
jsonwithout the use ofgeojsonmodule.Since geojson data from file can now directly be read from json module also update the docs to reflect on this. Link: https://mattijn.github.io/topojson/example/input-types.html#geojson-data-from-file