Fix None to 'null' when calling Topology.to_json(pretty=True) #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizongk
changed the title
yizongk
force-pushed
the
fix_none_to_json_with_pretty
branch
from
705e65c
to
35c8ef6
Compare
|
Thanks for the PR! Looks good👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current version, when you call Topology.to_json(pretty=True) on data with properties set to None, it will output None in the result. None is not valid JSON syntax, None should be replace with null
For more info, please look at this issue: #149
This PR includes a fix to that issue, and a test case for the test suite