Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the issue of geojson attribute visualization #151

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

natsuapo
Copy link
Contributor

The issue is mentioned here: #146

I modify the extract part. I think it can pass most of the test. But I am not sure whether there are still potential fails.

@natsuapo natsuapo closed this Mar 30, 2022
@natsuapo natsuapo reopened this Mar 30, 2022
@natsuapo
Copy link
Contributor Author

natsuapo commented Mar 30, 2022

I found that this version of topojson cannot be read by some topojson libraries like the JavaScript one. I thought it is something wrong in my code, but I find that the original one cannot do that too. I am checking this part.

I found the issue is not related to this library, so I keep this merge request.

@mattijn mattijn merged commit 753b58a into mattijn:master Mar 31, 2022
@mattijn
Copy link
Owner

mattijn commented Mar 31, 2022

Thanks, this is great. Much appreciated

@mattijn
Copy link
Owner

mattijn commented Mar 31, 2022

Hm, a bit too quick. There were indeed still some tests failing. I cannot decipher upon first glance if these are false flags, but before this PR all tests were still passing.

@mattijn
Copy link
Owner

mattijn commented Mar 31, 2022

I've reverted my merging. I'm not sure exactly if you still can add commits to this PR or if you have to open a new PR, since this is marked as merged.

@natsuapo
Copy link
Contributor Author

natsuapo commented Apr 1, 2022

I am sorry, I thought the test failing was just the path problem. I will test more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants