-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to rotate rings to avoid split #180
Add support to rotate rings to avoid split #180
Conversation
In comments, just for future reference
…lse' into Add-support-to-rotate-rings-to-avoid-split
First, thanks for this PR! I like it how you rotate to the first junction part in the I can imagine this reduce the workload in the Dedup class where it tries to merge arcs when possible. As mentioned in the inline comme t, maybe we can track the type directly during extraction? Also would be great if this PR only reflect the changes regarding the rotation. |
It's possible, but I don't think there is an advantage in denormalizing this information in "permanent" structures as we only need access to it via linestring index in this specific code path? I might be wrong, but I also doubt it would give a measurable performance benefit?
I made the changes independent of possible changes to the join logic. |
Thanks for making this PR more compact. All tests pass. Thanks for pushing! |
Remark: depends on #179 to be merged first!
Support rotating rings in
cut
to avoid unneeded splits happening.I noticed that there is some logic in
dedup
that merges adjacent lines:references #178