Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default shared_coords from True to False #190

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

mattijn
Copy link
Owner

@mattijn mattijn commented Sep 4, 2022

This PR changes the default from shared_coords from True to False. The impact is that computed topologies will use by default the strategy of path-connected (shared_coords=False), where before the default was coords-connected (shared_coords=True).
See for more info on the differences in the docs: https://mattijn.github.io/topojson/example/settings-tuning.html#shared_coords.

@mattijn
Copy link
Owner Author

mattijn commented Sep 4, 2022

The previous default was mainly there because of performance reasons. With #179 by @theroggy the performance differences are nearly identical, giving more preference to a new default.

@mattijn mattijn merged commit 220ffe2 into master Sep 4, 2022
@theroggy
Copy link
Contributor

theroggy commented Sep 8, 2022

fixed #187

@mattijn mattijn deleted the change-shared_coords-default-from-True-to-False branch September 20, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants