Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP refactoring classes for improving inheritance #24

Merged
merged 8 commits into from
Jul 18, 2019

Conversation

mattijn
Copy link
Owner

@mattijn mattijn commented May 18, 2019

Initialy I had trouble with memory pointers and deep copys of the input data objects. Therefor there were special functions that makes copies of the input data before it is given to the class.

This PR should make these functions obsolete.

Now the sequence of classes is called through the super() function in the __init__ of each class.
The order of class execution is hereby fixed by code and there is no need to read it up.

Also this PR should improve the accessibilty of possible settings as object in the package.

@mattijn mattijn changed the title only include remote_theme in _config.yml refactoring classes for improving inheritance May 18, 2019
@mattijn mattijn changed the title refactoring classes for improving inheritance WIP refactoring classes for improving inheritance May 18, 2019
@mattijn mattijn merged commit 8fd130c into master Jul 18, 2019
@mattijn mattijn deleted the inherit-through-super branch July 18, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant