Fix hashmap and topology errors #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix 7 broken tests that were committed in 1646ee7.
The tests regarding the
Hashmapclass, can now correctly parse nested geometry collections which could not parsehashmapperbefore .The tests regarding the
.to_geojson()also can now correctly parse nested geometry collections, and combinations of both points and polygons. This is quite cumbersome, since line strings and polygons are supported through a top-levelarcsobject, but coordinates of point and multipoint types are stored within the object itself (which can be quantized).Default the
prettyandvalidatein the.to_json()andto_geojson()toFalse.Last, bump version to
rc9, which can be released now since all 136 tests pass.