Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a default set of inputs from lorem ipsum text. #29

Closed
hewhomustnotbenamed opened this issue Oct 12, 2016 · 10 comments
Closed

Have a default set of inputs from lorem ipsum text. #29

hewhomustnotbenamed opened this issue Oct 12, 2016 · 10 comments

Comments

@hewhomustnotbenamed
Copy link

hewhomustnotbenamed commented Oct 12, 2016

Can use a switch --use-default-text to load some text from lorem ipsum so as to get a quick combination of random words.

Also maybe text could be loaded from url instead of just static files.

@mattjegan
Copy link
Owner

Yeah, I think this could be a good use case. Would you like to work on this? If so, please submit a PR for the --use-default-text implementation and then another for any url features since that could get tricky 😄

@hewhomustnotbenamed
Copy link
Author

Sure!! Can you assign this issue to me?

On Oct 15, 2016 5:59 AM, "Matthew Egan" notifications@github.com wrote:

Yeah, I think this could be a good use case. Would you like to work on
this? If so, please submit a PR for the --use-default-text implementation
and then another for any url features since that could get tricky 😄


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#29 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADOciUFJM0kbdXu4_4d-a-Vh_fvw7I2fks5q0B59gaJpZM4KUqL5
.

@mattjegan
Copy link
Owner

All done, you're good to go 😄

@mattjegan
Copy link
Owner

Hey @hewhomustnotbenamed , are you still happy to do this?

@mattjegan
Copy link
Owner

I'm going to label this as help wanted in case anyone wants to pick it up

@the-c0d3r
Copy link
Contributor

I would like to help with this enhancement. I'm not clear if I should setup a argument handling using --use-default-text or just write another method inside the RanCat class? And how to store a passage of "Lorem ipsum" in a file or as a variable? Please bear with me since I'm quite new to writing modular approach.

@mattjegan
Copy link
Owner

Hey, thanks for reaching out. I would probably suggest adding a new argparse argument --use-default-text which would set the source files as 2 lorem ipsum files which you can store in a new folder rancat/assets/

@the-c0d3r
Copy link
Contributor

I am sorry for replying so late. I was waiting for the email notification but I didn't catch that.

I have a few questions. This project is supposed to work as a module to be imported, not as a stand-alone program is it not? As I understand it there is no argument handling for code working as a module. Can you please clarify? I would really like to contribute in this.

@mattjegan
Copy link
Owner

Ahh I'm so sorry, I must've written this late at night and been confused with another project. You are completely right, Rancat is imported as a python module

In such case I recommend implementing something like Rancat.load_default() which would pull from files located in rancat/assets/

Let me know if you get stuck.

@the-c0d3r
Copy link
Contributor

I have created a pull request for this feature. I don't know if I did it correctly or not. Please feel free to comment on my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants