Update LogonUser. Fixes #2.

mattjohnsonpint · Oct 8, 2013 · 95f9144 · 95f9144
1 parent 046cc9b
commit 95f9144
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/SimpleImpersonation/Impersonation.cs b/SimpleImpersonation/Impersonation.cs
@@ -18,13 +18,15 @@ public static Impersonation LogonUser(string domain, string username, string pas
 
         private Impersonation(string domain, string username, string password, LogonType logonType)
         {
-            var ok = NativeMethods.LogonUser(username, domain, password, (int)logonType, 0, out _handle);
+            IntPtr handle;
+            var ok = NativeMethods.LogonUser(username, domain, password, (int)logonType, 0, out handle);
             if (!ok)
             {
                 var errorCode = Marshal.GetLastWin32Error();
                 throw new ApplicationException(string.Format("Could not impersonate the elevated user.  LogonUser returned error code {0}.", errorCode));
             }
 
+            _handle = new SafeTokenHandle(handle);
             _context = WindowsIdentity.Impersonate(_handle.DangerousGetHandle());
         }
 

diff --git a/SimpleImpersonation/NativeMethods.cs b/SimpleImpersonation/NativeMethods.cs
@@ -8,7 +8,7 @@ namespace SimpleImpersonation
     internal class NativeMethods
     {
         [DllImport("advapi32.dll", SetLastError = true, CharSet = CharSet.Unicode)]
-        internal static extern bool LogonUser(String lpszUsername, String lpszDomain, String lpszPassword, int dwLogonType, int dwLogonProvider, out SafeTokenHandle phToken);
+        internal static extern bool LogonUser(String lpszUsername, String lpszDomain, String lpszPassword, int dwLogonType, int dwLogonProvider, out IntPtr phToken);
 
         [DllImport("kernel32.dll")]
         [ReliabilityContract(Consistency.WillNotCorruptState, Cer.Success)]

diff --git a/SimpleImpersonation/SafeTokenHandle.cs b/SimpleImpersonation/SafeTokenHandle.cs
@@ -1,11 +1,15 @@
-using Microsoft.Win32.SafeHandles;
+using System;
+using Microsoft.Win32.SafeHandles;
 
 namespace SimpleImpersonation
 {
     internal sealed class SafeTokenHandle : SafeHandleZeroOrMinusOneIsInvalid
     {
-        private SafeTokenHandle()
-            : base(true) { }
+        internal SafeTokenHandle(IntPtr handle)
+            : base(true)
+        {
+            this.handle = handle;
+        }
 
         protected override bool ReleaseHandle()
         {