(#37) feature: selecting a sensible terminal, configurable terminal command, and notifying when we can't open it #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and notifying when we can't open it
mattkae
force-pushed
the
feature/sensible-terminal
branch
from
938b3e0
to
86af102
Compare
OPNA2608
suggested changes
Feb 25, 2024
Co-authored-by: Cosima Neidahl <opna2608@protonmail.com>
I'm just using |
OPNA2608
reviewed
Feb 26, 2024
src/miracle_config.cpp
Outdated
Comment on lines
17
to
24
| char buffer[512]; | ||
|
|
||
| snprintf( | ||
| buffer, | ||
| sizeof buffer, | ||
| "command -v %s > /dev/null 2>&1", | ||
| name | ||
| ); |
There was a problem hiding this comment.
Don't know if it would make sense to ensure that name length doesn't exceed however much space is left in buffer after everything else, otherwise a long name could cut off parts (or the entirety) of > /dev/null 2>&1.
mattkae
changed the title
mattkae
changed the title
Conan-Kudo
pushed a commit
to Conan-Kudo/miracle-wm
that referenced
this pull request
Apr 23, 2024
…minal command, and notifying when we can't open it (mattkae#40) * feature: selecting a sensible terminal, configurable terminal command, and notifying when we can't open it * bugfix: using CMAKE_INSTALL_BINDIR for miracle-wm-sensible-terminal Co-authored-by: Cosima Neidahl <opna2608@protonmail.com> * enhancement: update program_exists check wihout bounds check --------- Co-authored-by: Cosima Neidahl <opna2608@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
sudo make install). The sensible terminal command needs to be found in your pathterminal: MY_COMMAND_STRINGkey in the config filelibnotify