Skip to content
This repository has been archived by the owner. It is now read-only.

Bug: Shifted time when using minute specific starting times #344

Closed
Fatih75 opened this Issue May 31, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Fatih75
Copy link

Fatih75 commented May 31, 2016

Hi matt,

Thanks for fixing all bugs and issues within a blink of an eye!
There is a small bug with the selected time when adding or dragging an Event in the scheduler.

Bug description

When the day-view-start/end is set to a half hour, like 9:30, the grid is rendered perfectly.
But the time on each block is shifted 30 minutes.

selection_105

However, This does not occur when you click on a the timespan.
In addition to issue #340, the on-timespan-click method now works perfectly by returning the correct time.

selection_106

Plunker

http://plnkr.co/edit/T0xk4OMqpdWldgTrbozk?p=preview

Related issues

Issue #340 - Bug: day-view-start time only works with exact hours

Kind regards,

@Fatih75

This comment has been minimized.

Copy link
Author

Fatih75 commented May 31, 2016

Edit

It seems that the bug is not only related to the minute specific starting times...
This bug also occurs when an exact hour is set, it also occurs when the day-view-start is NOT set.

The problem might be the rendering of the day view grid.
The grid on all days BEFORE the current day is different.
Plunker demonstrating the bug : http://plnkr.co/edit/wTVVSPRYSkYI3GyMihnH?p=preview

When a minute specific time is set, the days before AND after are also different
http://plnkr.co/edit/JBAZz0?p=preview

Figured this out because i was looking at the kitchen sink example : https://mattlewis92.github.io/angular-bootstrap-calendar/#?example=kitchen-sink
The events ( and day view grid ) on the days before the current date are shifted by 1 hour.

It might be related to version 0.20.1.

@mattlewis92

This comment has been minimized.

Copy link
Owner

mattlewis92 commented Jun 1, 2016

Looks like the fix for 0.20.1 broke a lot of other things, I've reverted it in 0.20.2 for now until I have the time to fix it properly.

@mattlewis92

This comment has been minimized.

Copy link
Owner

mattlewis92 commented Jul 25, 2016

Apologies for the late reply on this, I ended up rebuilding the entire day view logic from scratch in the end!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.