-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to latest istanbul api #79
Conversation
I'm guessing the build failed because Node.js 6 is no longer supported by the new packages that I installed. Istanbuljs itself only runs their CI tests from Node.js 8 and upwards. I'm also removing tests on Travis for Node.js 6 in this PR then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you so much for doing this migration, I really appreciate it! I left a couple of small comments. Also would it be possible for you to update the readme with the links to the latest reporter options? Thanks! 😄
Thanks for the review! I updated the commits with the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you! 😄
Released as |
Congrats on this, so happy to see such a big size decrease! https://packagephobia.now.sh/result?p=karma-coverage-istanbul-reporter |
The package
istanbul-api
is deprecated.See https://github.com/istanbuljs-archived-repos/istanbul-api
I migrated the code to use the new packages.
This brings in new underlying features of the istanbuljs library that I wish to use.
For example
lcov
has been changed to use relative paths and made the project root configurable.