Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to latest istanbul api #79

Merged
merged 2 commits into from
May 1, 2020
Merged

feat: upgrade to latest istanbul api #79

merged 2 commits into from
May 1, 2020

Conversation

sebastianhaeni
Copy link
Collaborator

The package istanbul-api is deprecated.
See https://github.com/istanbuljs-archived-repos/istanbul-api

I migrated the code to use the new packages.
This brings in new underlying features of the istanbuljs library that I wish to use.

For example lcov has been changed to use relative paths and made the project root configurable.

@sebastianhaeni
Copy link
Collaborator Author

sebastianhaeni commented Apr 29, 2020

I'm guessing the build failed because Node.js 6 is no longer supported by the new packages that I installed. Istanbuljs itself only runs their CI tests from Node.js 8 and upwards.
See https://travis-ci.org/github/istanbuljs/istanbuljs

I'm also removing tests on Travis for Node.js 6 in this PR then.

Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you so much for doing this migration, I really appreciate it! I left a couple of small comments. Also would it be possible for you to update the readme with the links to the latest reporter options? Thanks! 😄

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
src/reporter.js Outdated Show resolved Hide resolved
src/reporter.js Outdated Show resolved Hide resolved
@sebastianhaeni
Copy link
Collaborator Author

Thanks for the review! I updated the commits with the suggested changes.
Please have a look again.

Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! 😄

@mattlewis92 mattlewis92 changed the title refactor: migrate from istanbul-api to istanbul-lib-* feat: upgrade to latest istanbul api May 1, 2020
@mattlewis92 mattlewis92 merged commit 28cbbfb into mattlewis92:master May 1, 2020
@mattlewis92
Copy link
Owner

Released as 3.0.0, thanks for your contribution! 🎉

@XhmikosR
Copy link

XhmikosR commented May 2, 2020

Congrats on this, so happy to see such a big size decrease!

https://packagephobia.now.sh/result?p=karma-coverage-istanbul-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants