Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for retry delay to be generated based on retry count #40

Merged
merged 1 commit into from
May 10, 2022

Conversation

dr3
Copy link
Collaborator

@dr3 dr3 commented May 10, 2022

Allow retryDelay to be a string code of function to generate the delay time

More than happy to change implementation if you prefer a different method

@dr3
Copy link
Collaborator Author

dr3 commented May 10, 2022

@mattlewis92 👋 Hey, great package! Wondered if you would consider this change, as we would like the ability to have to delay increase e.g 500, 1000, 1500 etc

mattlewis92
mattlewis92 previously approved these changes May 10, 2022
Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattlewis92 mattlewis92 reopened this May 10, 2022
@mattlewis92 mattlewis92 changed the title Add support for retry delay to be generated based on retry count feat: add support for retry delay to be generated based on retry count May 10, 2022
@mattlewis92 mattlewis92 merged commit 11a48d8 into mattlewis92:master May 10, 2022
@dr3 dr3 deleted the retryDropoff branch May 10, 2022 14:55
@mattlewis92
Copy link
Owner

Released as 3.1.0, thanks for your contribution! 🥳

@dr3
Copy link
Collaborator Author

dr3 commented May 10, 2022

Fantastic, thanks @mattlewis92 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants