-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for multiple retries #5
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 13 16 +3
Branches 2 3 +1
=====================================
+ Hits 13 16 +3
Continue to review full report at Codecov.
|
@mattlewis92 Did you get a chance to review this PR? |
@b1rdex I have updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released as |
Summary
I have added support for multiple retries via a config parameter
maxRetries
whose default value is 1.This PR has the following changes:
maxRetries
option.maxRetries
is 1.getCacheBustString
every time.Update
maxRetries
.&retryAttempt=attemptValue
in the query string to track retryAttempt.This closes #4