Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit message #101

Merged
merged 4 commits into from
Jun 15, 2019
Merged

edit message #101

merged 4 commits into from
Jun 15, 2019

Conversation

HotspurHN
Copy link
Contributor

No description provided.

MINSK\Siarhei_Kurylkin added 3 commits June 14, 2019 18:30
@HotspurHN
Copy link
Contributor Author

ezgif com-video-to-gif

@@ -0,0 +1,45 @@
<template>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cojalvo
Copy link

cojalvo commented Jun 15, 2019

Any chance to add also delete button on hover?

@mattmezza mattmezza merged commit 1ac3082 into mattmezza:master Jun 15, 2019
@mattmezza
Copy link
Owner

This is awesome! :) 👏

@cojalvo is right, a delete button would be much appreciated (even though we should find a better UX for both edit and delete – maybe right clic contextual menu?)

@mattmezza
Copy link
Owner

@HotspurHN thanks for the PR, really adding value 👍

Please provide meaningful commit messages for next works :)

@HotspurHN
Copy link
Contributor Author

@cojalvo yeah will work on that next week. Not hard at all, even easier then making edit i think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants