Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config dir on macOS #3

Closed
bndw opened this issue Mar 28, 2023 · 0 comments · Fixed by #4
Closed

Config dir on macOS #3

bndw opened this issue Mar 28, 2023 · 0 comments · Fixed by #4

Comments

@bndw
Copy link
Contributor

bndw commented Mar 28, 2023

Minimal configuration. Need to be at ~/.config/algia/config.json

On macOS this actually defaults to $HOME/Library/Application Support/algia/config.json as per os.UserConfigDir, which is not ideal.

I think the most straightforward way to get macOS clients to use the ~/.config dir is to replace os.UserConfigDir with a 3rd party package like github.com/mitchellh/go-homedir. If this is an acceptable solution let me know - I'd be happy to submit a pull request.
bndw added a commit to bndw/algia that referenced this issue Mar 30, 2023
@bndw
fix: load config on macOS
815d379 
On macOS, `os.UserConfigDir` returns `$HOME/Library/Application Support`
and not `~/.config`. This patch uses a module that works across OSes.

Fixes mattn#3
@bndw bndw mentioned this issue Mar 30, 2023
Merged
bndw added a commit to bndw/algia that referenced this issue Apr 1, 2023
@bndw
fix: load config on macOS
cab839f 
On macOS, `os.UserConfigDir` returns `$HOME/Library/Application Support`
and not `~/.config`. This patch uses a module that works across OSes.

Fixes mattn#3
bndw added a commit to bndw/algia that referenced this issue Apr 4, 2023
@bndw
fix: load config on macOS
4362ad1 
On macOS, `os.UserConfigDir` returns `$HOME/Library/Application Support`
and not `~/.config`.

Fixes mattn#3
@mattn mattn closed this as completed in #4 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: load config on macOS bndw/algia
1 participant
@bndw