Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added create map type #304

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Added create map type #304

merged 1 commit into from
Feb 14, 2019

Conversation

MichaelS11
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #304 into master will increase coverage by <.01%.
The diff coverage is 93.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   91.86%   91.87%   +<.01%     
==========================================
  Files           9        9              
  Lines        2176     2215      +39     
==========================================
+ Hits         1999     2035      +36     
- Misses        115      117       +2     
- Partials       62       63       +1
Impacted Files Coverage Δ
vm/vmExpr.go 96.32% <93.02%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324fd7c...8705586. Read the comment docs.

@MichaelS11
Copy link
Contributor Author

@mattn Good to merge

@mattn
Copy link
Owner

mattn commented Feb 14, 2019

Should we add to the modification of README.md to clarify that anko treat map[string]interface{} and map[interface{}]interface {} separately?

@MichaelS11
Copy link
Contributor Author

@mattn How are they treated differently? If they are, I am not aware how they are treated differently.

a = map[interface]interface {"b":"b"}; a.b // b
a = map[string]interface {"b":"b"}; a.b // b

@mattn
Copy link
Owner

mattn commented Feb 14, 2019

Is this related on #264, isn't ?

@MichaelS11
Copy link
Contributor Author

A little. Mostly it is for people to have basically the same syntax as Go. The only difference is that interface{} type is interface, which is not ideal but what works.

@mattn
Copy link
Owner

mattn commented Feb 14, 2019

Thanks for your explaining.

@mattn mattn merged commit 7ab1f7f into mattn:master Feb 14, 2019
@MichaelS11 MichaelS11 deleted the map branch February 14, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants