Correct implementation of NewPixbufFromData via gdk_pixbuf_new_from_data #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document in README Add contributor
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
NewPixbufFromDataseems using some assumptions about howgdk_pixbuf_loader_writeshould work, and anyway does not document properly how to use it. (we probably should have tests for these functions).After some struggles I individuated in
gdk_pixbuf_new_from_datathe correct API counterpart for it.This PR uses
gdk_pixbuf_new_from_datainstead ofgdk_pixbuf_loader_writeand additionally defines aPixbufDatastruct for embedding/inlining of pixbuf data from files; additionally, a CLI tool (to be used with//go:generate) is provided intools/to generate such pixbuf data automatically.Inspiration for the embedding/inlining approach: https://github.com/krh/gtk/blob/master/gdk-pixbuf/make-inline-pixbuf.c
Upstream documentation: https://developer.gnome.org/gdk-pixbuf/stable/gdk-pixbuf-Image-Data-in-Memory.html#gdk-pixbuf-new-from-data