-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination not working with GetTimelinePublic and Mastodon 2.6.5 #86
Comments
@178inaba Can you handle this issue? |
@mattn OK! |
I confirmed the following response in the Link header.
It seems that this change came in at 2.6.0.
I will show my recognition as an example. For example, suppose you have a status ID like the one below. In this case, the response should be as follows.
@marians Can you submit your pull request to this repository? |
@178inaba I'd rather not do that. Because (a) the change is trivial and (b) according to my understanding, especially from your comment, this will break pagination for servers < 2.6.0. |
@marians Thank you. |
Thanks! Not sure when I'll be able to test this. Will close for now. |
@178inaba Thank you so much! |
I tried using go-mastodon against the
https://chaos.social
instance, which uses version 2.6.5 according to https://chaos.social/api/v1/instance, with following code:This quits with the output
which is coming from
go-mastodon/mastodon.go
Line 296 in 4def10a
I have an experimental fix that works for me here for the simple purpose of the above code: https://github.com/marians/go-mastodon/pull/1/files
My understanding of the Mastodon API version differences is not deep enough to tell when
min_id
has been introduced, where it is used, whethersince_id
is still in use etc. So I can't provide a PR currently that makes pagination work in all cases. Hopefully the description is enough for others to do so. Thanks!The text was updated successfully, but these errors were encountered: