Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Media struct and UploadMediaFromMedia method #130

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

178inaba
Copy link
Contributor

@178inaba 178inaba commented Jul 26, 2020

@codecov-commenter
Copy link

Codecov Report

Merging #130 into master will decrease coverage by 0.75%.
The diff coverage is 37.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   80.10%   79.35%   -0.76%     
==========================================
  Files          29       29              
  Lines        1503     1511       +8     
==========================================
- Hits         1204     1199       -5     
- Misses        205      219      +14     
+ Partials       94       93       -1     
Impacted Files Coverage Δ
status.go 74.48% <31.70%> (-11.14%) ⬇️
mastodon.go 74.00% <100.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e91c76...8345c00. Read the comment docs.

}

// UploadMediaFromMedia uploads a media attachment from a Media struct.
func (c *Client) UploadMediaFromMedia(ctx context.Context, media *Media) (*Attachment, error) {
Copy link
Contributor Author

@178inaba 178inaba Jul 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UploadMediaFromMedia 🤔

Let me know if have a good name! 😄

@mattn
Copy link
Owner

mattn commented Jul 27, 2020

Thank you

@mattn mattn merged commit 315df7d into mattn:master Jul 27, 2020
@178inaba 178inaba deleted the media_upload branch July 27, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add description to attachments
3 participants