Go 1.3 will require you to change (*C.OCIServer)(s.c.svc) to (*C.OCISvcCtx)(s.c.svc)

[andlabs]

In Go 1.2 and earlier, any C struct that is only declared, never defined, and used only via pointers ("sealed") was turned into [0]byte. This meant that mismatched struct types went undetected. Go 1.3 gets rid of this behavior, making each declared struct type unique.

Your code has, in several places, lines of the form

    rv := C.OCIStmtExecute(
        (*C.OCIServer)(s.c.svc),

However, according to the docs, the first parameter to OCIStmtExecute() must be a OCISvcCtx. So the code will need to be changed to

    rv := C.OCIStmtExecute(
        (*C.OCISvcCtx)(s.c.svc),

to compile in Go 1.3.

This was discovered while trying to get this package working for @RGidron on his Mavericks setup on Gopher Academy's Slack server; after working with him for a bit I found this error (I was familiar with this misbehavior when it broke my ui package when it tried to use Cairo types).

[mattn]

Currently, I don't have Oracle environment. Could you please send me a pull-request?

[peterhellberg]

I’m having the same issue when building on 1.3

[mattn]

OK, I merged this. But I did't make sure this change is working. Sorry.

[mattn]

@peterhellberg Ah, sorry, I notice you are making PR.

[peterhellberg]

@mattn No problem :)

[peterhellberg]

@mattn You mistyped OCISvcCtx though! 🙅

[mattn]

Oooops. Could you please check last comit?

[peterhellberg]

@mattn Yes, it now compiles under both OS X and Linux (Ubuntu)

I’m using the latest versions of the Instant Client for both platforms (11.2 and 12.1 respectively)

[mattn]

Thanks!