Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why http/1.0 is forced? #4

Closed
23doors opened this issue Jun 6, 2017 · 9 comments
Closed

Why http/1.0 is forced? #4

23doors opened this issue Jun 6, 2017 · 9 comments

Comments

@23doors
Copy link
Collaborator

23doors commented Jun 6, 2017

Any particular reason why http/1.0 is forced here:
https://github.com/mattn/go-uwsgi/blob/master/uwsgi.go#L251 and here https://github.com/mattn/go-uwsgi/blob/master/uwsgi.go#L273 ?

@mattn
Copy link
Owner

mattn commented Jun 6, 2017

I'm not sure, I don't remember, but maybe, when I tested this, the server did not return a response. This is workaround.

@23doors
Copy link
Collaborator Author

23doors commented Jun 6, 2017

Thanks for quick answer!
Tried removing these 2 lines and everything seemed to be working fine at least for http/1.1 but I haven't done any extensive tests. And I am running it behind a uwsgi (internal routing) which may for some reason yield different results than running it behind nginx + uwsgi pass.

@mattn
Copy link
Owner

mattn commented Jun 6, 2017

If you solve your issue, please send me p-r.

@23doors
Copy link
Collaborator Author

23doors commented Jun 6, 2017

#5

@23doors
Copy link
Collaborator Author

23doors commented Jun 6, 2017

Any chance you could take a look? If you don't have time right now, I'll just use my fork for the time being

@mattn
Copy link
Owner

mattn commented Jun 9, 2017

Test fails. Could you handle this? https://travis-ci.org/mattn/go-uwsgi

@23doors
Copy link
Collaborator Author

23doors commented Jun 9, 2017

Made a fix for regression: #6 but actually it seems that tests were failing for a long time now. Fixed the error, but tests seem to hang anyway. I tested version before PR - and it also hangs on me so it doesn't seem to be a regression. Sadly, I don't have time right now to debug what is wrong with the testcase especially as it looks unfinished.

Anyway. TestBasic should work after this PR.
TestServer is another story though.
From what I gathered:

passenger := &Passenger{"tcp", "127.0.0.1"}

this is wrong, no port in addr - and server that it points to is not running

l, err := net.Listen("tcp", "127.0.0.1:0")

listener is declared but unused. And yet we later on try to connect to it which causes timeout.

@mattn
Copy link
Owner

mattn commented Jun 10, 2017

I removed TestServer now because I don't remember what I want to test.

@mattn
Copy link
Owner

mattn commented Sep 8, 2017

closed by #8

@mattn mattn closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants