Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug with URL encoded image src #21

Merged
merged 1 commit into from Oct 8, 2021
Merged

fix bug with URL encoded image src #21

merged 1 commit into from Oct 8, 2021

Conversation

stephenafamo
Copy link
Contributor

Using fmt.Fprintf instead of fmt.Fprint made URL encoded image src values as formatting tokens which broke images such as ![](http://example.com/undici%20external%20calls)

@mattn
Copy link
Owner

mattn commented Oct 8, 2021

Good catch.

@mattn mattn merged commit aa55d03 into mattn:master Oct 8, 2021
@mattn
Copy link
Owner

mattn commented Oct 8, 2021

Thank you

@stephenafamo stephenafamo deleted the fix/img-src branch October 8, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephenafamo @mattn