Add gitlab support

[agamm]

Fixes #191

[coveralls]

Coverage decreased (-0.1%) to 10.978% when pulling 7595826 on agamm:add-gitlab-support into f1c5f0d on mattn:master.

[gdm85]

Thanks for submitting this PR!

I am requesting some changes here and also I think the CI_MERGE_REQUEST_ID or CI_MERGE_REQUEST_IID should be covered to get the Merge Request ID (corresponding to PR number)

[agamm]

Thanks for submitting this PR!

I am requesting some changes here and also I think the CI_MERGE_REQUEST_ID or CI_MERGE_REQUEST_IID should be covered to get the Merge Request ID (corresponding to PR number)

I didn't really understand what you meant by: CI_MERGE_REQUEST_IID, did my changes relate? Also I didn't find where to test this part of the code.

[gdm85]

I didn't really understand what you meant by: CI_MERGE_REQUEST_IID, did my changes relate? Also I didn't find where to test this part of the code.

Your PR introduces use of CI_EXTERNAL_PULL_REQUEST_IID for the PR number; that is only valid when building a GitHub project on GitLab (see https://docs.gitlab.com/ee/ci/variables/predefined_variables.html). If you are building a MR on GitLab using a GitLab project, then you need either CI_MERGE_REQUEST_ID or CI_MERGE_REQUEST_IID (I suspect the latter).

Can you please verify?

[agamm]

CI_MERGE_REQUEST_ID

I work by mirroring my github to gitlab so I can't really verify that super easily. What did you have in mind, I'll do my best?
PS it seems that CI_MERGE_REQUEST_ID is more relevant. ("unique ID across all projects on GitLab")

[agamm]

I created a temporary repo to test this fork, I always got an ambigious message of a 500 error:

Bad response status from coveralls: 500
{"message":"Build processing error.","error":true,"url":""}

Pipeline example: https://gitlab.com/agmore1/testgoveralls/-/jobs/850406137
.gitlab-ci.yml: https://gitlab.com/agmore1/testgoveralls/-/blob/master/.gitlab-ci.yml

[gdm85]

I created a temporary repo to test this fork, I always got an ambigious message of a 500 error:

Bad response status from coveralls: 500
{"message":"Build processing error.","error":true,"url":""}

Pipeline example: https://gitlab.com/agmore1/testgoveralls/-/jobs/850406137
.gitlab-ci.yml: https://gitlab.com/agmore1/testgoveralls/-/blob/master/.gitlab-ci.yml

That sounds like a bug in coveralls.io itself; cc @nickmerwin

@agamm please update your project to use go get github.com/mattn/goveralls@master and then run it with with -debug=true, that might provide interesting clues for troubleshooting the server-side bug.

I work by mirroring my github to gitlab so I can't really verify that super easily. What did you have in mind, I'll do my best?
PS it seems that CI_MERGE_REQUEST_ID is more relevant. ("unique ID across all projects on GitLab")

I think what we need here is the MR ID, so that coveralls.io can link back to GitLab with the right reference. Similarly, for GitHub it's the PR number not the unique PR ID across all projects.

[agamm]

-debug=true

I tried updating from master but there were no new changes, I did change the merge request id to iid like you said, although I still honestly don't understand that part.

Seems to still fail:
https://gitlab.com/agmore1/testgoveralls/-/jobs/860029893

[agamm]

@gdm85 any update?

[gdm85]

@agamm that 500 is a bug on coveralls.io side; you can try using -shallow but they need to fix it on their side.

[afinetooth]

FYI @agamm and @gdm85, on behalf of coveralls, we provided a workaround for the current issue that entails adding the commit-sha to the base of your posted json. However, a fix will go to production in 24-48 hrs so please try again and let us know if it still occurs. thanks.