Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce build.Import calls when importing files from relative root #195

Merged
merged 3 commits into from
May 25, 2021
Merged

Reduce build.Import calls when importing files from relative root #195

merged 3 commits into from
May 25, 2021

Conversation

kylecarbs
Copy link
Contributor

@kylecarbs kylecarbs commented May 19, 2021 •
edited

Fixes lengthy uploads when used from repositories with lots of Go files.

This reduced our goveralls time from ~2m to ~8s.

@coveralls
Copy link

coveralls commented May 19, 2021 •
edited

Coverage Status

Coverage decreased (-0.3%) to 10.684% when pulling bd04b32 on kylecarbs:master into f28e79e on mattn:master.

@kylecarbs
Copy link
Contributor Author

cc: @shogo82148

shogo82148
shogo82148 approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks!

@shogo82148 shogo82148 merged commit 021e47b into mattn:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylecarbs @coveralls @shogo82148