Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diverse improvments #13

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Diverse improvments #13

merged 2 commits into from
Nov 19, 2019

Conversation

AdrieanKhisbe
Copy link
Contributor

Adding support for syntax highlight in markdown blocks along with repo reorganisation.

:)

mattn
mattn requested changes Mar 15, 2019
View reviewed changes
Copy link
Owner

@mattn mattn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you rename this?

.vscode/launch.json Outdated Show resolved Hide resolved
patch.diff Outdated Show resolved Hide resolved
@AdrieanKhisbe
Copy link
Contributor Author

AdrieanKhisbe commented Mar 15, 2019 •
edited
Loading

Why do you rename this?

@mattn What this do you refer?

(Will apply your requests :))

@mattn
Copy link
Owner

mattn commented Mar 15, 2019

You are renaming syntaxes.orig/Lisp.tmLanguage to syntaxes/original/Lisp.tmLanguage.

@AdrieanKhisbe
Copy link
Contributor Author

A yeah, I did it to reorganise the project. (to keep a root folder syntaxes)
If you don't want that, tell me. I'll remove it also

@AdrieanKhisbe
Copy link
Contributor Author

You are renaming syntaxes.orig/Lisp.tmLanguage to syntaxes/original/Lisp.tmLanguage.

Shall I cancel that?
Or do you aggree with my comment? (#13 (comment))

@AdrieanKhisbe
Copy link
Contributor Author

@mattn I applied your requests

@AdrieanKhisbe
Copy link
Contributor Author

@mattn Good for you now? :)

@AdrieanKhisbe
Copy link
Contributor Author

Sorry to bother you @mattn, but I'll be glad if you could have a look.
Best regards

@mattn mattn merged commit 772d0cd into mattn:master Nov 19, 2019
@mattn
Copy link
Owner

mattn commented Nov 19, 2019

Thank you. Sorry my delay.

@mattn
Copy link
Owner

mattn commented Nov 19, 2019

I'll ship in later.

@AdrieanKhisbe
Copy link
Contributor Author

@mattn cool! :)
Thanks you a lot too, and No problem for the delay by the way =)

@AdrieanKhisbe AdrieanKhisbe deleted the diverse-improvments branch November 19, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattn mattn mattn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AdrieanKhisbe @mattn