Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.9 of OpenSsl #69

Merged
merged 12 commits into from
Feb 8, 2018
Merged

Update to version 0.9 of OpenSsl #69

merged 12 commits into from
Feb 8, 2018

Conversation

Luxed
Copy link
Contributor

@Luxed Luxed commented Oct 29, 2017

Well... It's not working because of the ssl is moved... and I cannot figure out how to do it...

This branch does not have the modifications from the master branch (ftp correction). But right now, neither is working.

@Luxed
Copy link
Contributor Author

Luxed commented Oct 29, 2017

And I feel dumb seeing that someone already tried to do this....

@Luxed
Copy link
Contributor Author

Luxed commented Oct 29, 2017

This solved #63 and #64.

Tests need to be updated to send a SslContext to enter secure mode.

@Luxed
Copy link
Contributor Author

Luxed commented Oct 29, 2017

Issues:

use ftp::openssl::ssl::*;

Does not contain SslContext (for some unknown reason), which seems to be the reason why the build fails.

@Luxed
Copy link
Contributor Author

Luxed commented Nov 6, 2017

No more issues !

I would be happy if the code was reviewed and merged @mattnenterprise. Future work on this library depend on this update.

@mattnenterprise mattnenterprise merged commit c392899 into mattnenterprise:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants