Escape password and other astring tokens #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
reviewed
Nov 2, 2017
src/client.rs
Outdated
| @@ -601,7 +607,7 @@ mod tests { | |||
| let response = b"a1 OK Logged in\r\n".to_vec(); | |||
| let username = "username"; | |||
| let password = "password"; | |||
| let command = format!("a1 LOGIN {} {}\r\n", username, password); | |||
| let command = format!("a1 LOGIN {} {}\r\n", quote!(username), quote!(password)); | |||
There was a problem hiding this comment.
Not sure what happened to the indentation here?
|
Looks good to me! See the one inline comment about a weird indent; once that's fixed, I'd be happy to merge. |
Rebased by rhn <gihu.rhn@porcupinefactory.org>
|
Thanks for noticing the indent - I removed some more tabs I previously missed, should be good now. |
|
Hmm, still there as far as I can tell? Are you sure you pushed to the right branch? |
Some notable exceptions: messagebox names are defined as `INBOX / astring`, but with this change, INBOX is also quoted. The `list-mailbox` token is not quoted, as it is not `astring`.
|
Rebasing is hard. I added a commit fixing indentation to be done with tabs. |
|
Haha, okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to @gcollura's pull request #20 , which seems somewhat stalled.
Differences: