Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ext_modules definition in setup.py #12

Merged
merged 7 commits into from Feb 24, 2021

Conversation

duncanmmacleod
Copy link
Contributor

This PR cleans up the definition of the extension module in setup.py. Most of the change is style, the only substantive change is to remove the unnecessary gslcblas link.

@duncanmmacleod duncanmmacleod marked this pull request as draft February 24, 2021 14:43
@mattpitkin
Copy link
Owner

From the build failure it looks like gslcblas is required.

@duncanmmacleod
Copy link
Contributor Author

From the build failure it looks like gslcblas is required.

I think this is a linking issue in libgs23 for ubuntu-18.04, it clearly needs libgslclas itself but isn't linked against it. This is corrected on the ubuntu-20.04 image.

@duncanmmacleod duncanmmacleod marked this pull request as ready for review February 24, 2021 15:06
@mattpitkin mattpitkin merged commit e5b1497 into mattpitkin:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants