Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): remove wee_alloc #158

Merged
merged 10 commits into from
Sep 29, 2023
Merged

build(deps): remove wee_alloc #158

merged 10 commits into from
Sep 29, 2023

Conversation

afonsobarracha
Copy link
Contributor

@afonsobarracha afonsobarracha commented Sep 26, 2023

Description

wee_alloc is no longer maintained and has memory leaks, so I am removing that feature. We will now default to the rust standard allocator, to insure this is always the best version it can be we will use a recent version of rust.

To ensure the maximum possible performance from the standard allocator, the rust edition will be updated to 2021, and the rustup version will be set at 1.72.x, currently the newest version of rust.

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Fix security vulnerabilities, we_alloc is no longer maintained and seems to have a memory leak, hence we will remove this feature and always default to the rust standard allocator.

Does this PR introduce a breaking change?

  • Yes
  • No

This PR has two breaking changes:

  • wee_alloc feature flag is removed;
  • Rust edition goes from 2018 to 2021, to take advantage of the new default rust WASM allocator.
  • Fixes the CI to rust version 1.72.x

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@afonsobarracha afonsobarracha merged commit b929d7d into master Sep 29, 2023
17 checks passed
@afonsobarracha afonsobarracha deleted the ab/remove-wee-alloc branch September 29, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants