-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): remove wee_alloc #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasileiosKal
approved these changes
Sep 26, 2023
afonsobarracha
force-pushed
the
ab/remove-wee-alloc
branch
from
September 26, 2023 21:47
3a5c188
to
fca0881
Compare
afonsobarracha
force-pushed
the
ab/remove-wee-alloc
branch
from
September 27, 2023 21:22
9fc8dbc
to
62495d2
Compare
mate-from-mattr
previously approved these changes
Sep 28, 2023
mate-from-mattr
approved these changes
Sep 28, 2023
BasileiosKal
approved these changes
Sep 28, 2023
colinyip
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wee_alloc
is no longer maintained and has memory leaks, so I am removing that feature. We will now default to the rust standard allocator, to insure this is always the best version it can be we will use a recent version of rust.To ensure the maximum possible performance from the standard allocator, the rust edition will be updated to 2021, and the
rustup
version will be set at 1.72.x, currently the newest version of rust.Motivation and Context
Fix security vulnerabilities, we_alloc is no longer maintained and seems to have a memory leak, hence we will remove this feature and always default to the rust standard allocator.
Does this PR introduce a breaking change?
This PR has two breaking changes:
wee_alloc
feature flag is removed;Which merge strategy will you use?