Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proof Create and Verify to benchmarks #62

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

TelegramSam
Copy link
Contributor

And a few error reporting fixes in the library.
Note: this fails if more than one attribute is revealed. PR contains improved error label, shown here:

Error: internal error in Neon module: Index is out of bounds. Must be between 0 and 1: 2

And a few error reporting fixes in the library.
Copy link
Member

@tplooker tplooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, couple of minor comments

bench/index.ts Outdated Show resolved Hide resolved
bench/index.ts Outdated Show resolved Hide resolved
src/bbsSignature.ts Outdated Show resolved Hide resolved
bench/helper.ts Outdated Show resolved Hide resolved
also fixed reveal numbers to avoid errors in benchmarks.
@tplooker tplooker merged commit e85a5ed into mattrglobal:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants